-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: cleanup script cb #13161
ci: cleanup script cb #13161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one small question
@@ -10,9 +10,13 @@ phases: | |||
- ts-node ./wait-for-all-codebuild.ts $CODEBUILD_RESOLVED_SOURCE_VERSION ../$WAIT_FOR_IDS_FILE_PATH $PROJECT_NAME | |||
- cd .. | |||
- source ./shared-scripts.sh && _downloadReportsFromS3 $CODEBUILD_SOURCE_VERSION | |||
- mkdir artifacts && echo "empty artifact" > artifacts/empty-artifact.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed for cleanup script or just an unrelated change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just needed any artifact, as the cleanup job depends on the aggregate job to finish; Codebuild requires 'some' file to be produced in order to depend on a job
Description of changes
Cleanup script for Codebuild which focuses on stale resources, by @goldbez .
In short, this just runs the cleanup script without any parameters, so that it scans through each e2e test account and deletes old resources.
Successful run here https://tiny.amazon.com/kyjz1b29/IsenLink
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.